Thank you so much for becoming a php.js contributor!
Here are a few pointers that could save us from disappointment, we'll keep it brief:
- By submitting a Pull Request you are giving php.js permission to distribute your code under the MIT License.
- Please adhere to our coding standards.
- Please credit yourself in the function's header-comment:
(original by|improved by|bugfixed by|revised by|input by): Your Name (http://your.url) - If you're fixing bad behavior, please add an
examplethat would fail before your patch, and aresultthat passes after your patch, to the function's header-comment - Since we are mimicking PHP, our
array_functions need to accept Objects, which is the closest thing to the hash-table like data-structure that PHP calls an array. Please keep this in mind as you're proposing optimizations. - Sometimes we place
forinsideiffor performance reasons, even if the code could be twice as small if we did this the other way around.