Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the requirement to check the "Show Docker Extensions system containers" option #39

Closed
aborroy opened this issue Feb 3, 2023 · 2 comments
Closed

Remove the requirement to check the "Show Docker Extensions system containers" option #39

aborroy opened this issue Feb 3, 2023 · 2 comments
Assignees
@aborroy

Comments

@aborroy
Copy link
Contributor

aborroy commented Feb 3, 2023

The Extension requires "Show Docker Extensions system containers" option checked in Docker Settings to work.

docker-extension-settings

This option includes Containers from extensions to be listed in Docker Desktop, that may be confusing for final users.
@aborroy aborroy self-assigned this Feb 3, 2023
@aborroy
Copy link
Contributor Author

aborroy commented Feb 3, 2023

Containers created using the v1.DockerDesktopClient are identified as Extension Containers. This is the reason why the Alfresco Docker Extension doesn't work to get information from Alfresco Containers when the option is unchecked, because all cli operations (like docker ps) are filtering these containers (as they are considered to be "Docker Extension system containers").

The patch must be able to create regular Docker Containers from the Docker Extension API.

@aborroy
Copy link
Contributor Author

aborroy commented Feb 21, 2023

An alternative way should be using container name, like described in:
docker/extensions-sdk#225

aborroy added a commit that referenced this issue Mar 7, 2024
@aborroy
#39 List containers using "inspect" command
407070c 
This avoids requiring "Show Docker Extensions system containers" options to be checked in Docker Desktop
aborroy added a commit that referenced this issue Mar 11, 2024
@aborroy
Merge pull request #40 from AlfrescoLabs/feature/remove-extension-con…
36a83b7 
…tainers-check

#39 List containers using "inspect" command
@aborroy aborroy closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborroy aborroy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aborroy