Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rust bitcoin deserialize_hex when upgrading version #94

Open
RCasatta opened this issue Aug 9, 2024 · 0 comments
Open

Use rust bitcoin deserialize_hex when upgrading version #94

RCasatta opened this issue Aug 9, 2024 · 0 comments

Comments

@RCasatta
Copy link
Collaborator

RCasatta commented Aug 9, 2024 

          Unrelated to this PR, but I noticed `tx_from_value` (and `block_from_value`) could probably be improved by using rust bitcoin `deserialize_hex` which doesn't allocate the intermediate vector of bytes.

Just noticed the rust bitcoin version we are currently using doesn't have that yet, leaving this here anyway if we want to upgrade in the future.

Originally posted by @RCasatta in #89 (comment)
junderw added a commit to junderw/electrs that referenced this issue Sep 4, 2024
@junderw
Merge pull request Blockstream#94 from mempool/mononaut/fix-summary-t…
7fc4912 
…x-ordering

Fix summary tx ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RCasatta