Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated and unnecessary --ignore-gpu-blacklist flag in Better Chromium #2647

Open
3 tasks done
glanduin opened this issue Sep 16, 2024 · 3 comments
Open
3 tasks done
Labels
suggestion New feature or request

Comments

@glanduin
Copy link

Confirmations

What happened?

Not much. It is just a typo in the code i assume.

Description

In the installation script of Better Chromium, there is this line (501)

flags="--ignore-gpu-blacklist --enable-checker-imaging --cc-scroll-animation-duration-in-seconds=0.6 --disable-quic --enable-tcp-fast-open --enable-experimental-canvas-features --enable-scroll-prediction --enable-simple-cache-backend --max-tiles-for-interest-area=512 --num-raster-threads=4 --default-tile-height=512 --enable-features=VaapiVideoDecoder,VaapiVideoEncoder,ParallelDownloading --disable-features=UseChromeOSDirectVideoDecoder --enable-accelerated-video-decode --enable-low-res-tiling --process-per-site"

I think the "ignore-gpu-blacklist" should be "ignore-gpu-blocklist" instead, to be correct. To go to that particular flag in Chromium you need to type:

chrome://flags/#ignore-gpu-blocklist

What are your system specs (run the following command in your terminal)?

OS: Debian GNU/Linux 12 (bookworm)
OS architecture: 64-bit
Last updated Pi-Apps on: 09/16/2024
Latest Pi-Apps version: 09/16/2024
Kernel: aarch64 6.6.47+rpt-rpi-2712
Device model: Raspberry Pi 5 Model B Rev 1.0
SOC identifier: bcm2712
Cpu name: Cortex-A76
Ram size: 4.04 GB
Raspberry Pi OS image version: 2024-03-15
Language: en_US.UTF-8

(Recommended) Error log? Terminal output? Debug messages?

No response

@glanduin glanduin added the bug Something isn't working label Sep 16, 2024
Copy link
Contributor

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

@theofficialgman
Copy link
Collaborator

I think the "ignore-gpu-blacklist" should be "ignore-gpu-blocklist" instead, to be correct

Its not a typo. That used to be the command but they renamed it mid 2020 (https://chromium-review.googlesource.com/c/chromium/src/+/2289414) and then removed compatibility with the original in late 2020 (https://chromium-review.googlesource.com/c/chromium/src/+/2540668).

This doesn't necessitate an immediate change as it isn't required to have hardware acceleration.

@theofficialgman theofficialgman added suggestion New feature or request and removed bug Something isn't working labels Sep 16, 2024
@theofficialgman theofficialgman changed the title Possible typo in Better Chromium script remove deprecated and unnecessary --ignore-gpu-blacklist flag in Better Chromium Sep 16, 2024
@Botspot
Copy link
Owner

Botspot commented Sep 16, 2024

I think the name change was due to some people thinking "blacklist" is a racist term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants