Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment editor tests pass even when they should fail #1199

Closed
chia-yh opened this issue Jun 29, 2023 · 0 comments · Fixed by #1200
Closed

Comment editor tests pass even when they should fail #1199

chia-yh opened this issue Jun 29, 2023 · 0 comments · Fixed by #1200

Comments

@chia-yh
Copy link
Contributor

chia-yh commented Jun 29, 2023

Describe the bug
As mentioned in #1197 (comment), some of the expect statements in the async tests in comment-editor.component.spec.ts seem to never execute, leading to tests passing even when they should fail.

To Reproduce
Steps to reproduce the behavior:

  1. Locate one of the async tests, e.g.
    it('should allow users to input text', async () => {
  1. Edit the expect statement to intentionally fail, e.g.
      fixture.whenStable().then(() => {
        expect(textBox.value).toEqual('');
      });
  1. npm run test
  2. All tests are executed successfully

Expected behavior
The expect statement edited to fail should cause the particular test to fail

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version [e.g. 22]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant