-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB2-3258 Web server Python Upgrade to 3.11.9 #1246
BB2-3258 Web server Python Upgrade to 3.11.9 #1246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to get more eyes on this, but I can log in, authorize, use the test client, use django, and run selenium tests locally without issue. I think the python version for compiling requirements should be 3.11, but I'm not certain it's causing any present problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp38 wheels can be removed:
BB2-3258-Web-Server-python-upgrade-from-3.8-to-3.11-noor$ ls -al vendor | grep cp38
-rw-r--r-- 1 jimfuqian-mac-pro staff 26106 Sep 16 11:07 MarkupSafe-2.1.5-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 736569 Sep 16 11:07 PyYAML-6.0.1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 74033 Sep 16 11:07 backports.zoneinfo-0.2.1-cp38-cp38-manylinux1_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 442655 Sep 16 11:07 cffi-1.15.1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 195879 Sep 16 11:07 charset_normalizer-3.1.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 3119131 Sep 16 11:07 debugpy-1.6.7-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 754948 Sep 16 11:07 newrelic-8.8.0-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 4420553 Sep 16 11:07 pillow-10.3.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 3017926 Sep 16 11:07 psycopg2_binary-2.9.6-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
nice to see mock sls Dockerfile updated to 3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JIRA Ticket:
BB2-3258
What Does This PR Do?
This PR upgrades the Python version from the previous version to Python 3.11.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)