Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3258 Web server Python Upgrade to 3.11.9 #1246

Merged

Conversation

noor1027
Copy link
Contributor

@noor1027 noor1027 commented Sep 11, 2024

JIRA Ticket:
BB2-3258

What Does This PR Do?

This PR upgrades the Python version from the previous version to Python 3.11.

What Should Reviewers Watch For?

  1. Ensure that all dependencies in requirements.txt or other package management files are compatible with Python 3.11.
  2. Ensure that any changes related to type annotations or syntax updates introduced in Python 3.11 are correctly implemented.
  3. Look for any missing or unclear instructions on setting up Python 3.11 locally or in deployment environments.

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@noor1027 noor1027 marked this pull request as ready for review September 13, 2024 12:51
Copy link
Contributor

@loganbertram loganbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to get more eyes on this, but I can log in, authorize, use the test client, use django, and run selenium tests locally without issue. I think the python version for compiling requirements should be 3.11, but I'm not certain it's causing any present problems.

docker-compose.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
requirements/requirements.dev.txt Show resolved Hide resolved
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp38 wheels can be removed:

BB2-3258-Web-Server-python-upgrade-from-3.8-to-3.11-noor$ ls -al vendor | grep cp38
-rw-r--r-- 1 jimfuqian-mac-pro staff 26106 Sep 16 11:07 MarkupSafe-2.1.5-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 736569 Sep 16 11:07 PyYAML-6.0.1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 74033 Sep 16 11:07 backports.zoneinfo-0.2.1-cp38-cp38-manylinux1_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 442655 Sep 16 11:07 cffi-1.15.1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 195879 Sep 16 11:07 charset_normalizer-3.1.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 3119131 Sep 16 11:07 debugpy-1.6.7-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 754948 Sep 16 11:07 newrelic-8.8.0-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 4420553 Sep 16 11:07 pillow-10.3.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-rw-r--r-- 1 jimfuqian-mac-pro staff 3017926 Sep 16 11:07 psycopg2_binary-2.9.6-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

@JFU-NAVA-PBC
Copy link
Contributor

nice to see mock sls Dockerfile updated to 3.11

Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noor1027 noor1027 merged commit e87d0dd into master Sep 17, 2024
6 checks passed
@noor1027 noor1027 deleted the noor1027/BB2-3258-Web-Server-python-upgrade-from-3.8-to-3.11 branch September 17, 2024 16:04
@noor1027 noor1027 restored the noor1027/BB2-3258-Web-Server-python-upgrade-from-3.8-to-3.11 branch September 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants