Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3353 Initialize oAuth and allow logout flow in openapi #1247

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

stiwarisemanticbits
Copy link
Contributor

@stiwarisemanticbits stiwarisemanticbits commented Sep 12, 2024

JIRA Ticket:
BB2-3353

What Does This PR Do?

Initialize oAuth and allow logout flow in openapi

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tweaked openapi.yaml to point to BB2 local server and verified that authorization with an app registered with the local bb2 works as expected:

  1. logout button shown after auth flow
  2. fetched resources after auth flow
  3. click logout
  4. fetch resources again got 401 with error:
  5. {
    "detail": "Authentication credentials were not provided."
    }

@JFU-NAVA-PBC
Copy link
Contributor

the additions looks good.

@stiwarisemanticbits stiwarisemanticbits merged commit d559e6b into master Sep 20, 2024
6 checks passed
@stiwarisemanticbits stiwarisemanticbits deleted the stiwarisemanticbits/BB2-3353-logout branch September 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants