Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert boolean value in profile page to yes/no #263 #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Imsurajr
Copy link

@Imsurajr Imsurajr commented Jun 19, 2023

Fixes #

Describe the changes you have made in this PR - As assigned, I had to change the boolean (True/False) value to more understandable (Yes/No). I did the same.

I ran
flutter format
flutter analyze
flutter test
and did not encountered any error.

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@Imsurajr Imsurajr changed the title Git checkout b convert boolean value in profile page to yes/no #263 Convert boolean value in profile page to yes/no #263 Jun 20, 2023
Copy link
Member

@vedant-jain03 vedant-jain03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-singh7
Copy link
Member

@Imsurajr could you fix the ci?

@Imsurajr
Copy link
Author

Imsurajr commented Jun 25, 2023

@aman-singh7 The intl 0.18.0 was not compatible with dart 3, I had to downgrade dart sdk's version to work on this project, try running it on the lower version which will support intl 17 , there it will work fine, if you try to run it on dart 3, other deprecated packages will also cause error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants