Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inherited test cases (e.g., VnePmMigration) #6

Open
maxkratz opened this issue Jul 28, 2021 · 1 comment
Open

Refactor inherited test cases (e.g., VnePmMigration) #6

maxkratz opened this issue Jul 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@maxkratz
Copy link
Member

Currently, there are various test classes that inherit a super test class and just overwrite the method to create a new algorithm instance to test. As this is a bad coding style, one may refactor the test cases to parametrized tests to remove the high number of classes for each test case.

Example file: https://github.com/maxkratz/iflye/blob/1bc84da8d29f8ef0b6f89b848bca2d90db743fe0/test.suite/src/test/algorithms/pm/migration/VnePmMdvneAlgorithmMigrationTotalCommunicationCostATest.java#L21

@maxkratz maxkratz added the enhancement New feature or request label Sep 4, 2021
@maxkratz
Copy link
Member Author

maxkratz commented Sep 4, 2021

Just a small update on this issue: This is only possible for (sub-)test classes that do not overwrite test cases of their parent classes.

Example: https://github.com/maxkratz/iflye/blob/fa3be77acb493b88dd5744f21cddae7727be79a2/test.suite/src/test/algorithms/pm/pipeline/VnePmMdvneAlgorithmPipelineTwoStagesRackATotalCommunicationCostATest.java#L27-L33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant