Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base context file will show wrong number of pulses for SA1/3 #83

Open
philsmt opened this issue Aug 30, 2023 · 2 comments
Open

Base context file will show wrong number of pulses for SA1/3 #83

philsmt opened this issue Aug 30, 2023 · 2 comments

Comments

@philsmt
Copy link
Contributor

philsmt commented Aug 30, 2023

return run[xgm_name, 'pulseEnergy.numberOfBunchesActual'].xarray()

By chance I noticed that the base context file uses the numberOfBunchesActual property, which contains the sum of SA1/SA3 pulses in those respective tunnels:

image

This may be confusing to someone starting with the base context file at these SASEs. If you want to continue using the XGM as data source here, one could try to infer the topic you're running in from the XGM's device ID.

@JamesWrigley
Copy link
Member

I wonder if we could shave this yak another way by using the XGM component in the context file, and getting the component to infer the topic it's in 🤔

@philsmt
Copy link
Contributor Author

philsmt commented Aug 30, 2023

Yes, definitely. As it happens I already got plenty of topic/instrument/sase-inferring code in the pulse components, which I meant to abstract away into some utils anyway together with device-locating code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants