Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: JUNGFRAU stripsel #170

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DRAFT: JUNGFRAU stripsel #170

wants to merge 4 commits into from

Conversation

tmichela
Copy link
Member

This implements geometry for the JUNGFRAU stripsel module.

The implementation is slow and dirty, but I probably won't have much time to work on that in the next months, so that should allow working with it with the proper interface (and hopefully let someone with more time to improve it :) )

it's based on the requirements give on this ticket.
We don't have sample data yet for testing.

@philsmt
Copy link
Contributor

philsmt commented Aug 24, 2022

Note for later: All functions should accept both untransformed data in the regular shape as well as already transformed data without transforming it.

@takluyver
Copy link
Member

The reorganisation changes the array shape, doesn't it? So we can check the shape of a single module frame to see whether it's got already transformed data.

@philsmt
Copy link
Contributor

philsmt commented Aug 25, 2022

Yes, for the time being that should work out. I say time being as Marco hinted at further strixel-type sensors coming in with varying layouts, but this is all quite murky as of yet how they will distinguish themselves... we might ultimately require a generic pixel-reordering-machinery for (JF) detectors.

I tripped over this in the JF correct notebook, as naturally I want to reorder the pixels early after corrections, but then still plot it with EXtra-geom afterwards.

@takluyver
Copy link
Member

OK, so maybe we'll want an option to specify if the data is already transformed, and fall back to guessing based on the shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants