Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pgRouting A star #4263

Draft
wants to merge 216 commits into
base: move_routing_to_backend
Choose a base branch
from
Draft

Use pgRouting A star #4263

wants to merge 216 commits into from

Conversation

justinefricou
Copy link
Contributor

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@cypress Cypress
Copy link

cypress bot commented Aug 12, 2024 •
edited
Loading

Geotrek-admin    Run #9959

Run Properties:  status check passed Passed #9959  •  git commit 4eb7826322 ℹ️: Merge d39e682841caea86a2a70d6f7b4e6638273301b6 into 6729f20e2e26126e6af2088cd073...
Project Geotrek-admin
Branch Review refs/pull/4263/merge
Run status status check passed Passed #9959
Run duration 02m 00s
Commit git commit 4eb7826322 ℹ️: Merge d39e682841caea86a2a70d6f7b4e6638273301b6 into 6729f20e2e26126e6af2088cd073...
Committer Justine Fricou
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (use_pgRouting@08359c5). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             use_pgRouting    #4263   +/-   ##
================================================
  Coverage                 ?   98.38%           
================================================
  Files                    ?      268           
  Lines                    ?    20984           
  Branches                 ?        0           
================================================
  Hits                     ?    20645           
  Misses                   ?      339           
  Partials                 ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JustineFricou added 27 commits August 28, 2024 09:34
@justinefricou
Add TrekGeometry view with get and post methods
97b3ab4
@justinefricou
Add a parameter to TrekGeometry post method
58766b1
@justinefricou
Add graph and steps info being sent to TrekGeometry view
74f0477
@justinefricou
Add computing of the dijkstra matrix and start and end nodes (only ha…
6e16158 
…ndling whole edges with their default direction)
@justinefricou
Add computing of the path to follow (node to node) (handles whole edg…
b200b87 
…es with their default direction)
@justinefricou
Modify path in response: it's now from start to end
c0e554c
@justinefricou
Refacto: nodes idx to id correspondence
f356ab9
@justinefricou
Add structure of algorithm handling partial edges and more than 2 steps
5feecc1
@justinefricou
ADD handling of edge percentage and more than 2 markers
113995a
@justinefricou
Add display of a hard-coded polyline sent from the TrekGeometry view
165d6ed
@justinefricou
The graph is directly taken from the backend
188d969
@justinefricou
Add handling of GPS coordinates as input
253ef5b
@justinefricou
Add use of Point ewkt when using sql
5c31da3
@justinefricou
Add TODOs for next step: obtaining a LineString from dijkstra results
4305b0f
@justinefricou
Starting to work on converting the resulting nodes list into LineStrings
20ab44e
@justinefricou
Add conversion of dijstra results into a displayed Linestring
f6fd6c0
@justinefricou
Correctng some comments
e661685
@justinefricou
Fix path not computed if adjacent steps are on the same edge
4ad3bd9
@justinefricou
Fix negative dijkstra weight when we're going backwards relative to a…
c229a6c 
… Path direction
@justinefricou
Fix path not computed when going backwards on a Path if going through…
0ced117 
… several edges
@justinefricou
Starting to display fetched route instead of locally computed route
7fc0002
@justinefricou
Preparing topology_helper to handle several linestrings
0c7ea24
@justinefricou
Automating the geojson generation in the view
c5eea3b
@justinefricou
Add handling of several steps
93cfd65
@justinefricou
Replacing MultiLineString by GeometryCollection in Response
a03d6f7
@justinefricou
Fixing the organization of layers in the displayed path
7b8a371
@justinefricou
Removing old code related to the graph
89d842c
@justinefricou justinefricou mentioned this pull request Aug 30, 2024
Open
submarcos and others added 17 commits September 3, 2024 11:31
@submarcos
manage pgrouting in nstall scripts
0c736f5
@submarcos
enable pgrouting extension in debian postinst
f79d993
@justinefricou
Update benchmark system for pgRouting
473f1d3
@submarcos
fix tests and viewset permission
d0ed7f4
@submarcos
prevent flaky test
e87edeb
@submarcos
Merge branch 'move_routing_to_backend' into use_pgRouting
9972711
@submarcos
Update docs/install/import.rst
6ef6802
@submarcos
fix rebase
aa6cb6a
@submarcos
fix rebase
72e7eb2
@justinefricou @submarcos
Modify routing alorithm: use pgr A*
eaa86bc 
	- route is found
	- geometry's direction not correct yet
	- topology's directions and fractions not correct yet
@justinefricou @submarcos
Fix route topology extremities taking the whole edge
05c4b09
@justinefricou @submarcos
Fix direction of route topology and geometry
2cf3124
@justinefricou @submarcos
Fix generation of topology (start and end fractions)
316a3f8
@justinefricou @submarcos
Fix computation of more than 2 steps not possible: temp tables not dr…
c907b18 
…opped
@justinefricou @submarcos
Fix multilistrings sometimes not merging
b1721a7
@justinefricou @submarcos
Remove comments and prints
0c50091
@justinefricou @submarcos
Improve precision of coordinates rounding
2cdabcc
Base automatically changed from use_pgRouting to move_routing_to_backend September 13, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinefricou @submarcos