Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxGameJolt is using an outdated version of the gamejolt api #406

Open
Vortex2Oblivion opened this issue Sep 14, 2023 · 18 comments
Open

FlxGameJolt is using an outdated version of the gamejolt api #406

Vortex2Oblivion opened this issue Sep 14, 2023 · 18 comments

Comments

@Vortex2Oblivion
Copy link
Contributor

Any plans to update to the latest version?

@Geokureli
Copy link
Member

Geokureli commented Sep 16, 2023

This isn't a priority of mine, I'm not really a fan of the idea of there being an "official haxeflixel gamejolt" API. for my Newgrounds.io API I just made a framework agnostic API and made some OpenFL specific tools and demos.

I'll need to look into the current state of FlxGameJolt and what it takes to update it, but right now my gut says we should just remove the current one and link to some gamejolt haxelib in the External Tools wiki page

If you think FlxGameJolt has some value that is worth saving, than please list those reasons, here

@Vortex2Oblivion
Copy link
Contributor Author

I've tried using other gamejolt haxelibs specifically hxgamejolt-api (afaik this is the only haxelb that uses the latest gamejolt api) and for some reason when pinging the gamejolt servers to keep the session open it lags a lot for a second. Flxgamejolt doesn't o do this.

@Vortex2Oblivion
Copy link
Contributor Author

There is a changelog so it doesn't look super hard to bring it up to the latest version (it only shows what was changed from 1.1 to 1.2 for some reason though??) FlxGamejolt uses 1.0 of the gamejolt api so everything from 1.1 and 1.2 would need to be added.

@Geokureli
Copy link
Member

Geokureli commented Sep 16, 2023

I've tried using other gamejolt haxelibs specifically hxgamejolt-api (afaik this is the only haxelb that uses the latest gamejolt api) and for some reason when pinging the gamejolt servers to keep the session open it lags a lot for a second. Flxgamejolt doesn't o do this.

On which target do you see this issue?

Also if it seems to not be very complicated, you should try updating FlxGameJolt, as you seem much more familiar with it than I

@Vortex2Oblivion
Copy link
Contributor Author

Windows c++ target and I guess I could try upgrading it to the latest version.

@Vortex2Oblivion
Copy link
Contributor Author

Also if it seems to not be very complicated, you should try updating FlxGameJolt, as you seem much more familiar with it than I

Really the only annoying thing is that I can't find a changelog for 1.0 to 1.1 only from 1.1 to 1.2 so I will need to check the changelog at the bottom of each doc page to see if something was changed in between 1.0 and 1.1.

@Vortex2Oblivion
Copy link
Contributor Author

Also if it seems to not be very complicated, you should try updating FlxGameJolt, as you seem much more familiar with it than I

Really the only annoying thing is that I can't find a changelog for 1.0 to 1.1 only from 1.1 to 1.2 so I will need to check the changelog at the bottom of each doc page to see if something was changed in between 1.0 and 1.1.

Actually I could probably check archive.org or something for one

@MAJigsaw77
Copy link
Contributor

I've tried using other gamejolt haxelibs specifically hxgamejolt-api (afaik this is the only haxelb that uses the latest gamejolt api) and for some reason when pinging the gamejolt servers to keep the session open it lags a lot for a second. Flxgamejolt doesn't o do this.

(Not about the issue) The lag is fixed on the latest version of the lib (It's using threads for the Https requests now.

@Vortex2Oblivion
Copy link
Contributor Author

Oh sweet

@Geokureli
Copy link
Member

Geokureli commented Nov 14, 2023

Check it out and let me know if you still think FlxGameJolt is worth keeping

One idea to to gut FlxGameJolt and replace it with calls to the haxelib and wrap it in#if hxgamejolt_api. the downside is that changes to the haxelib may cause flixel CI errors without constant maintenance

@Vortex2Oblivion
Copy link
Contributor Author

Vortex2Oblivion commented Nov 15, 2023

I'm still not sure if Flxgamejolt should be removed but I feel like FlxKongregate could probably be removed. As said in #350 kongregate does not allow any new games into the website. However as someone in the issue said, I'm not sure if this would affect anyone who currently has a game on the website.

@SeiferTim
Copy link
Member

I'm still not sure if Flxgamejolt should be removed but I feel like FlxKongregate could probably be removed. As said in #350 kongregate does not allow any new games into the website. However as someone in the issue said, I'm not sure if this would affect anyone who currently has a game on the website.

Kongregate DOES allow new games - but not Flash. You have to sign up with them to get access to be able to add games, although I do not currently know what - if anything - is different with their API. This is something I have been just barely starting to research, but I am swamped by other things at the moment.

I have been given access to upload games, and I have been given access to look over their API documentation. I just don't have time to dig into it yet.

@Geokureli
Copy link
Member

Geokureli commented Nov 15, 2023

Kongregate DOES allow new games - but not Flash. You have to sign up with them to get access to be able to add games, although I do not currently know what - if anything - is different with their API. This is something I have been just barely starting to research, but I am swamped by other things at the moment.

Can you share where you found this? I was also under the impression they stopped taking ALL games, they stopped taking flash games long ago

Edit: Oh, there's new games

@SeiferTim
Copy link
Member

Kongregate DOES allow new games - but not Flash. You have to sign up with them to get access to be able to add games, although I do not currently know what - if anything - is different with their API. This is something I have been just barely starting to research, but I am swamped by other things at the moment.

Can you share where you found this? I was also under the impression they stopped taking ALL games, they stopped taking flash games long ago

Edit: Oh, there's new games

I submitted an application and received a response via email:

Thank you for submitting your game Monster Match with us. We will be happy to publish it on the Kongregate platform! Please, let me know what your username on Kongregate is (if you are already registered), and I will grant you the access to developers' features to upload the game on our website.

Please, feel free to check out our documentation here to start the integration process: https://docs.kongregate.com/docs/integration-overview. There are 3 main APIs for the moment: Authentication, Kreds (for micro-transactions) and High Scores.

However, I JUST found out they laid off a ton of people so I may not be working with them after all...

@Vortex2Oblivion
Copy link
Contributor Author

Check it out and let me know if you still think FlxGameJolt is worth keeping

One idea to to gut FlxGameJolt and replace it with calls to the haxelib and wrap it in#if hxgamejolt_api. the downside is that changes to the haxelib may cause flixel CI errors without constant maintenance

Maybe we could put a deprecation warning telling users to use an external haxelib instead since the class won't be maintained anymore? (or something like that idk)

@Geokureli
Copy link
Member

Maybe we could put a deprecation warning telling users to use an external haxelib instead since the class won't be maintained anymore? (or something like that idk)

im fine with this

@Vortex2Oblivion
Copy link
Contributor Author

Maybe we could put a deprecation warning telling users to use an external haxelib instead since the class won't be maintained anymore? (or something like that idk)

im fine with this

What about FlxKongregate though?🤔

@Geokureli
Copy link
Member

I don't personally want to spend time updating FlxKongregate or removing it, and it sounds like there's enough reason to do neither, if I understand correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants