Memory leak of Settings dialogue

[SilverBut]

In both current master branch and my issue-guis branch, the SettingsDialog is created for everytime you click Settings in menu. However, it is not destroyed after the dialogue got closed. This can be reproduced by adding a singleton class into the __init__ method of class SetingsDialog.

Fix related with this issue will be committed together with other code from #46.

[SilverBut]

Seems a possible solution: https://stackoverflow.com/questions/15674422/unable-to-detect-why-qdialog-is-memory-leaking

[SilverBut]

Seems a possible solution: https://stackoverflow.com/questions/15674422/unable-to-detect-why-qdialog-is-memory-leaking

Nope. Not the source. But fixed:

         def settingsActionTriggered():
-            SettingsDialog(self._plugin).exec_()
+            if self._settingsDialog == None:
+                self._settingsDialog = SettingsDialog(self._plugin)
+            self._settingsDialog.exec_()

[NeatMonster]

How did you confirm the memory leak? I read the documentation of QDialog::done and it appears to me that setting the Qt::WA_DeleteOnClose flag would be enough. Am I missing something?

[SilverBut]

How did you confirm the memory leak? I read the documentation of QDialog::done and it appears to me that setting the Qt::WA_DeleteOnClose flag would be enough. Am I missing something?

Open & close the settings menu using a script and monitor the memory usage ;)

[NeatMonster]

Sorry for the late reply @SilverBut. I've tested your pull request #52 but I'm still seeing a memory leak. Even if the dialog is reused, memory usage increases every time I open and close it. In all of my testing, the singleton method appears to be equivalent to using Qt::WA_DeleteOnClose.

[SilverBut]

Strange. The commit 2714069 should not create any more setting dialogues and its pages. Maybe it is not the dialog which is created for many times.
I may check it later. Kind of busy recently.

[NyaMisty]

I'm not mean to be offensive, but I wonder why we need to care about things like this?
IDArling and IDA aren't used in a large-scale or long-time running scenario, and memory leak for about several KB or MB or even ~10MB each time opening the settings window is quite acceptable, as no one will repeatedly open and close it.
I think we should focus on other main issues instead of this tiny mysterious memory leak

[patateqbool]

totally agree, just keep it in a corner of our head for when there will be no more issue :)).

[NyaMisty]

But I also suggest that we solve this issue when we already have a pre-release