Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include authors #9

Closed
3 tasks done
martinsramek opened this issue Apr 24, 2020 · 6 comments
Closed
3 tasks done

Include authors #9

martinsramek opened this issue Apr 24, 2020 · 6 comments

Comments

@martinsramek
Copy link

martinsramek commented Apr 24, 2020

Including authors from separate files is part of issue #1.
All the changes are done in the include_authors branch and will be merged into pandoc_cleanup once they're finished.

  • resolve issue with concatenating files with include-pandoc

  • add page breaks, so chapters begin on a new page

  • update README.md

@martinsramek
Copy link
Author

Issue with include-pandoc still not resolved. Concatenating files messes up the lines somehow.

@martinsramek
Copy link
Author

include-pandoc concatenates files differently than pandoc. It's necessary to include a blank line at the start of every file for it to be concatenated correctly.

@silverhook
Copy link

It's necessary to include a blank line at the start of every file for it to be concatenated correctly.

For this reason, I think an old convention was (still is, but no-one follows it?) to always leave an empty line at the end of every text file. We could just explicitly state this convention needs to be followed.

Would this work, @martinsramek ?

@martinsramek
Copy link
Author

It's necessary to include a blank line at the start of every file for it to be concatenated correctly.

For this reason, I think an old convention was (still is, but no-one follows it?) to always leave an empty line at the end of every text file. We could just explicitly state this convention needs to be followed.

Would this work, @martinsramek ?
Indeed, this works also. I like this solution more. A blank line at the beginning of a file seems weird.

@silverhook
Copy link

Ha! Apparently the “empty last line” has to do with POSIX standard.

@martinsramek
Copy link
Author

OK, I discovered the culprit. It was my editor which deleted empty lines at the end of a file. That's why I used the dumb workaround with the blank lines at the beginning of the files. Now every file has an empty line at the end and all is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants