Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test folder to package source distribution #259

Open
j-emberton opened this issue Jul 13, 2024 · 2 comments
Open

Add test folder to package source distribution #259

j-emberton opened this issue Jul 13, 2024 · 2 comments

Comments

@j-emberton
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Pyrealm is distributed from PyPI without the tests included. This means that anyone who wants to build Pyrealm themselves doesn't have direct access to the tests to verify their build.

This is relevant to people and orgs (e.g. anaconda etc) who like to build their own packages.

Describe the solution you'd like

Add the tests to the source distribution

@davidorme
Copy link
Collaborator

That seems sensible - I hadn't really looked at what is included in the source distribution. I explicitly included the pyrealm_build_data package in source, which is excluded from the binary distributions, but it doesn't include anything else needed to build and test the package, so the source distribution doesn't really stand alone.

It's not just tests, really - the docs should probably go in too?

@j-emberton
Copy link
Collaborator Author

Yes I'd agree documentation would be a useful addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants