Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF#1678492] usefully display self-signed "TOFU"-spectrum certs #3

Open
James-E-A opened this issue Aug 18, 2020 · 6 comments
Open
Labels
enhancement New feature or request Firefox-specific Only affects Mozilla Firefox and its WebExtension-using derivatives waiting on upstream Fix is blocked by browser vendors

Comments

@James-E-A
Copy link
Owner

we need them

consider starting out just hard-coding in all these: https://www.g2.com/products/zscaler-internet-access/competitors/alternatives until we get around to implementing #2

however—

don't put any pleasant logos representing non-Mozilla-approved certificates in the UI without a badge, ever!

@James-E-A James-E-A added the enhancement New feature or request label Aug 18, 2020
@James-E-A James-E-A added this to the AMO Publication milestone Aug 28, 2020
@James-E-A James-E-A changed the title icons for self-signed, TLSGateways, etc. usefully display self-signed "TOFU"-spectrum certs Sep 6, 2020
@James-E-A
Copy link
Owner Author

James-E-A commented Sep 6, 2020

I'm thinking "no" for the TLS MITM gateways, tbh

  • It's pointless to put e.g. "Palo Alto" when it's actually your employer that's viewing
  • But some of these gateways are operated by a central company

I'm just rounding these all up to "eye icon with a fuchsia badge" and calling it appropriately chosen.

(Third-party "Proper Root CAs", though, are another matter—at some point, I'll let the user manually review these per #2, but, in the meantime, I think CAcert is the only game in town [EDIT: seealso #20], so I've just hardcoded it in as an "alt" which gets tagged with a cyan badge.)


However, for self-signed, I'd love to be able to gatekeep these and certify them, but Mozilla has blocked me on this front.

@James-E-A James-E-A added the waiting on upstream Fix is blocked by browser vendors label Sep 6, 2020
@James-E-A
Copy link
Owner Author

James-E-A commented Sep 7, 2020

Suggestion: Check for securityInfo.state=="insecure" && url.protocol=="https:", and display a separate indicator for that, possibly with a link in the details to view this issue?

@James-E-A James-E-A added the wouldfix Closed, but only provisionally label Sep 7, 2020
@James-E-A
Copy link
Owner Author

@James-E-A James-E-A removed this from the AMO non-Experimental Release milestone Sep 7, 2020
@James-E-A
Copy link
Owner Author

don't put any pleasant logos representing non-Mozilla-approved certificates in the UI without a badge, ever!

Actually, I think we'll reverse this: have a particular badge which does display to certify Mozilla-approved connections (and badge others differently, nevertheless, to prevent spoofing).

This will also visually differentiate it from the badge-less "uninitialized" state.

I'll have to do a bit of cross-platform testing (and maybe offer a fallback), but the fox face emoji seems to work as a perfect badgeText, looking great with both LimeGreen and #00ff000000 badgeBackgroundColors.

@James-E-A
Copy link
Owner Author

James-E-A commented Sep 23, 2020

https://bugzilla.mozilla.org/show_bug.cgi?id=1549605#c25

has there been any thought given to whether the "secure" indicator (green padlock) should be given a different appearance? It's not specific to the current political situation, of course. I'd love to see a more obvious visible difference between "gmail.com, signed by Google" and "gmail.com, signed by Your Company's IT Department" (or of course "signed by Your Government's Secret Police").

When I add a per-site security exception for a self-signed cert, I get a black/dark-gray padlock with an overlaid yellow "warn" triangle. Would that be "too severe" for a user-installed root CA?

@James-E-A
Copy link
Owner Author

https://bugzilla.mozilla.org/show_bug.cgi?id=1678492

@James-E-A James-E-A added Firefox-specific Only affects Mozilla Firefox and its WebExtension-using derivatives and removed wouldfix Closed, but only provisionally labels Nov 20, 2020
@James-E-A James-E-A changed the title usefully display self-signed "TOFU"-spectrum certs [FF#1678492] usefully display self-signed "TOFU"-spectrum certs Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Firefox-specific Only affects Mozilla Firefox and its WebExtension-using derivatives waiting on upstream Fix is blocked by browser vendors
Projects
None yet
Development

No branches or pull requests

1 participant