Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing profiles #23

Open
cscherrer opened this issue Apr 19, 2020 · 2 comments
Open

Comparing profiles #23

cscherrer opened this issue Apr 19, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cscherrer
Copy link

This looks really useful:
https://github.com/google/pprof/blob/master/doc/README.md#comparing-profiles

Any experience using PProf in this way? I'm not sure what the most natural interface would be, maybe something allowing code to be run at two different commits? Or maybe the code executed should be allowed to change too, to account for interface updates?

@vchuravy
Copy link
Member

I am unsure that there is a good interface on our side, but you can always use

pprof(web=false, out=profile1.pb.gz)

To safe a particular profile and compare against it later.

@NHDaly
Copy link
Member

NHDaly commented Apr 19, 2020

Yeah, i've done what @vchuravy suggested.

I see two paths that could make this easier:

  1. We could probably support a diffbase flag, that lets you then point to the profile you exported via valentin's suggestion above.
  2. We could maybe provide a more convenient function to run the embedded pprof binary with arbitrary commands, so that you could do that yourself? Right now, we do this awkward thing internally, and we could instead make a nice function for this?:
    https://github.com/vchuravy/PProf.jl/blob/e142c4cab70cc51a9c50b0a12aac61dc59ff1090/src/PProf.jl#L259-L261

@NHDaly NHDaly added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants