Skip to content

Commit

Permalink
Merge #443
Browse files Browse the repository at this point in the history
443: Allow TOML as dependency of JLL packages r=DilumAluthge a=giordano

Since JuliaPackaging/BinaryBuilder.jl#1128 we also use TOML for JLLs in some cases.

Co-authored-by: Mosè Giordano <[email protected]>
  • Loading branch information
bors[bot] and giordano committed Apr 6, 2022
2 parents 0784251 + bd39ec6 commit 5f0aba4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/AutoMerge/jll.jl
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ function meets_allowed_jll_nonrecursive_dependencies(
# 3. Artifacts
# 4. JLLWrappers
# 5. LazyArtifacts
# 6. other JLL packages
# 6. TOML
# 7. other JLL packages
all_dependencies = _get_all_dependencies_nonrecursive(working_directory, pkg, version)
allowed_dependencies = ("Pkg", "Libdl", "Artifacts", "JLLWrappers", "LazyArtifacts")
allowed_dependencies = ("Pkg", "Libdl", "Artifacts", "JLLWrappers", "LazyArtifacts", "TOML")
for dep in all_dependencies
if dep allowed_dependencies && !is_jll_name(dep)
return false,
Expand Down
2 changes: 1 addition & 1 deletion src/AutoMerge/util.jl
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ function get_all_non_jll_package_names(registry_dir::AbstractString)
x in values(TOML.parsefile(joinpath(registry_dir, "Registry.toml"))["packages"])
]
sort!(packages)
append!(packages, values(RegistryTools.stdlibs()))
append!(packages, (RegistryTools.get_stdlib_name(x) for x in values(RegistryTools.stdlibs())))
filter!(x -> !endswith(x, "_jll"), packages)
unique!(packages)
return packages
Expand Down

2 comments on commit 5f0aba4

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: "Pre-release version not allowed"

Please sign in to comment.