Add CMake Config-file package #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to make the installed package relocatable.
kevinAlbs
changed the title
kou
reviewed
Jun 7, 2024
CMakeLists.txt
Outdated
| ) | ||
| write_basic_package_version_file( | ||
| "${CMAKE_CURRENT_BINARY_DIR}/utf8proc-config-version.cmake" | ||
| COMPATIBILITY AnyNewerVersion |
There was a problem hiding this comment.
It seems that utf8proc follows the semantic versioning. SameMajorVersion may be better.
README.md
Outdated
Comment on lines
45
to
54
| ## Using with CMake | ||
|
|
||
| A CMake Config-file package is provided. To use utf8proc in a CMake project: | ||
|
|
||
| ```cmake | ||
| add_executable (app app.c) | ||
| find_package (utf8proc 2.9.0 REQUIRED) | ||
| target_link_libraries (app PRIVATE utf8proc::utf8proc) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
It seems that Using other compilers is a subsection of Quick Start.
How about moving this after Using other compilers?
Co-authored-by: Sutou Kouhei <[email protected]>
utf8proc appears to use SemVer. Do not consider different major versions compatible.
|
Thank you for the review @kou. Feedback has been applied. |
kou
reviewed
Jun 9, 2024
kou
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #250 by creating CMake Config-file Package.
Motivation
https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#config-file-packages notes:
Including a CMake Config-file Package enables CMake consumers to use
find_packageto find and use utf8proc:The absence of a CMake Config-file Package may add difficulty using utf8proc in a CMake project. For example: the MongoDB C driver includes FindUtf8Proc.cmake using pkg-config. However, using pkg-config is not suitable for consumers building with MSVC (the
-land-Lflags are unrecognized).Use of relative paths in 422de38 is intended to make the installed package relocatable.