Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @test test_reference the API #81

Open
oxinabox opened this issue Feb 20, 2021 · 2 comments
Open

Make @test test_reference the API #81

oxinabox opened this issue Feb 20, 2021 · 2 comments

Comments

@oxinabox
Copy link
Member

oxinabox commented Feb 20, 2021

A significant problem with the current API is that using @test_reference means we can't do @test_broken @test_reference

But we could do that if we made the test_reference function the API,
and have it returning true or false rather than doing @test true and error(...).

We can keep the current @test_reference for backwards compatibility, via it just generating the @test test_reference(...).

@oxinabox
Copy link
Member Author

This would also make our tests much cleaner since we will be able to just @test !test_reference(...)

@oxinabox
Copy link
Member Author

this would be closed by #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant