Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprojects that contain the same name will be ignored #257

Open
Goooler opened this issue Jul 17, 2024 · 1 comment · May be fixed by #262
Open

Subprojects that contain the same name will be ignored #257

Goooler opened this issue Jul 17, 2024 · 1 comment · May be fixed by #262
Labels
enhancement New feature or request gradle

Comments

@Goooler
Copy link
Contributor

Goooler commented Jul 17, 2024

Declare subprojects in settings.gradle like:

include(
    ":sample",
    ":compose-multiplatform:library",
    ":compose-multiplatform:sample"
)

the structure should be:

├── compose-multiplatform
│   ├── library
│   └── sample
├── sample

then configure BCV in root build.gradle:

plugins {
    id("org.jetbrains.kotlinx.binary-compatibility-validator:0.15.1")
}

apiValidation {
    ignoredProjects += listOf(
        "sample"
    )
}

then dump APIs for them, compose-multiplatform:sample and sample projects are both ignored.

If we add compose-multiplatform:sample into ignoredProjects and run again, there will be an error:

Cannot find excluded project compose-multiplatform:sample in all projects: [root-project, compose-multiplatform, core, sample, library, sample]

as you can see, there are 2 projects listed here with the same name sample, they should be split.

@Goooler Goooler linked a pull request Jul 24, 2024 that will close this issue
@Goooler
Copy link
Contributor Author

Goooler commented Jul 25, 2024

Duplicate of #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gradle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants