Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights from working groups in n(z) estimation #3

Open
joezuntz opened this issue Aug 24, 2020 · 2 comments
Open

Weights from working groups in n(z) estimation #3

joezuntz opened this issue Aug 24, 2020 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@joezuntz
Copy link
Contributor

When the WGs pass you a collection of galaxies we've selected that we'd like the n(z) for, we may also need to pass you a weight per galaxy. The perfect n(z) would then be a weighted histogram of the true z values for each object.

I just wanted to make sure that was on your radar!

@aimalz
Copy link
Collaborator

aimalz commented Sep 3, 2020

Thanks for bringing this up @joezuntz! The Estimator class can accept subclass-specific information beyond the training and test set files already through its config file, so that functionality will already be built in when it's ready for extension into a Summarizer class. (@danielgruen and @jmccull might be interested in implementing an Estimator subclass that makes use of this functionality and/or writing unit tests for it, which can be started now by branching off this as-yet-unmerged but mature branch.)

@aimalz aimalz added enhancement New feature or request question Further information is requested labels Sep 15, 2020
@eacharles
Copy link
Collaborator

Nzdir seems to have weights that meet the stringent criteria of Joe. The others don't. We should come back to this.

@eacharles eacharles transferred this issue from LSSTDESC/rail_attic Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants