[FEATURE] Larger range for App Drawer 'Row height' (lower minimum value) #4663
Labels
Comments
|
How did you change it to 50%? 70% is much too large, I want to match it with my 7x15 homescreen |
I forked the project, changed the source and built a new APK. |
|
I've just upgraded to 0.14 beta 3 and it seems to have changed since beta2 - I'd never touched the row height before, but the App Drawer felt instantly different in how much space was between icons vertically. I have 2x Pixel 6a (stock ROMs), the one running the stock Pixel launcher still has a tighter row height than Lawnchair 0.14beta3 at 70%. To my untrained eye, a setting of 60% or 50% allowed in Lawnchair row height should/would match the default Android 14 Pixel 6a row height density when holding my two devices side by side, using a column count of 5 wide. $0.02 UPDATE: I discovered the root cause thanks to the above comment pointing at which source code they tweaked to test; it's this commit implementing two-line labels in the App Drawer, which is enabled by default in 0.14 beta 3: 7c34d0c Disabling that new setting (located at the very bottom of the App Drawer settings screen) restores the app drawer icon density to it's former glory at 100% row height and matches the stock Pixel launcher again as expected. Hope this helps. |
|
Thanks for the update. However, I like to have multiple line labels and really need a smaller "Row height" than is currently available to not have what I consider too much space between the rows. I found that allowing a smaller "Row height" (just by changing the lower limit in the UI) works for me. |
|
Nice! Thank you very much. |
|
Bug: App crashes when trying to access App Drawer settings I've just tried the latest nightly (Lawnchair.Debug.14-dev.Nightly-CI_1283-192cb03.apk) which includes commit 192cb03 and it crashes when you try to open the App Drawer settings. |
|
There's some floating point weirdness going on in the getSteps function in SliderPreference.kt. |
|
I'd rather not work with floating points as of now, so I just updated the minimum value to |
|
I'll just leave this here in case you'd like to use it to fix the root of the problem (in SliderPreference.kt). fun getSteps(valueRange: ClosedFloatingPointRange<Float>, step: Float): Int {
if (step == 0f) return 0
val start = valueRange.start.toBigDecimal()
val end = valueRange.endInclusive.toBigDecimal()
val test = (end - start) / step.toBigDecimal()
val steps = test.toInt()
require(test.compareTo(steps.toBigDecimal()) == 0) {
"value range must be a multiple of step"
}
return steps - 1
}I've tested it myself (in isolation and in a test build) and it seems pretty robust and works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
I'd like a lower minimum value for App Drawer 'Row height'.
I have a grid of 8 columns of icons (at 70% size) in the app drawer and find that the smallest 'Row height' of 70% still leaves a lot of space between the rows.
Having experimented with different values, I've found that a 'Row Height' of 50% works great for this scenario.
Why would it be useful to add?
Gives the user greater flexibility in configuring the app drawer.
Did the feature exist in Lawnchair v2? (Play Store version)
No
Example(s)
Current lowest value of 70%:
With lower value of 50%:
Additional context
No response
The text was updated successfully, but these errors were encountered: