Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload files #128

Open
ipeychev opened this issue Feb 27, 2018 · 5 comments
Open

Add ability to upload files #128

ipeychev opened this issue Feb 27, 2018 · 5 comments

Comments

@ipeychev
Copy link
Contributor

There is some odd issue with Magnet and uploading forms. To explain it, I created two examples: uploading files with and without Magnet. They are practically the same, but the one with Magnet throws "stream ended unexpectedly" error :/

How to reproduce:

  1. Download and unzip this zip file. It contains two examples for uploading files - with and without Magnet.
  2. Do "npm install" in each of the directories and then "npm run dev". Open the browser on "http://localhost:3000" and try to upload a file.

Expected result in the Magnet demo:
File to be uploaded successfully.

Actual result:
A "stream ended unexpectedly" exception is being thrown.

Note: there is sync and async version in Magnet example. Both throw same error. By defaut the demo works with the sync version.

For reference, the original example (without Magnet) I copied from here.

@zenorocha
Copy link

Is this still valid?

@ipeychev
Copy link
Contributor Author

It is, but it is not important. I believe no one is using this functionality and we can move it to backlog or even close it. If needed, we can reopen it.

@zenorocha
Copy link

Thanks @ipeychev!

@pragmaticivan
Copy link
Contributor

pragmaticivan commented May 15, 2018

If that's valid and still happens, I think we should not close the issue. Instead, we can just remove the labels.

@zenorocha zenorocha reopened this May 15, 2018
@zenorocha zenorocha changed the title Unable to upload a file Add ability to upload files May 15, 2018
@zenorocha
Copy link

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants