Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term lists linked from the "term tags" page lists words without that tag - blocked by 429 #448

Open
bwkimmel opened this issue Jun 12, 2024 · 1 comment
Labels
blocked bug Something isn't working

Comments

@bwkimmel
Copy link

Description

If you click on the number from an entry in the "Term tags" page, this takes you to a list of terms supposedly having that tag. However, this list may include words that do not have that tag. In particular, it includes any words that have the text of that tag as a substring of any field.

Related: #429, though presumably this could be fixed without fully implementing what's suggested there.

To Reproduce

Steps to reproduce the behavior, e.g.:

  1. Create a word and tag it as, say, "verb"
  2. Create another word, and define it's translation to be, say, "proverb"
  3. Go to the term tags list, and find the row for the "verb" tag. It will correctly indicate that there is only 1 word with that tag (the word created in step 1)
  4. Click on the number in that row. The resulting list of words will include "proverb", even though it is not tagged as "verb".

Screenshots

image

Extra software info, if not already included in the Description:

  • OS (e.g., iOS, windows): Windows 11 (Running Lute under Arch Linux in WSL2, though)
  • Browser (e.g., chrome, safari): Brave
  • How you've installed Lute (Docker, python, source): Python
  • Version: 3.4.2
@jzohrab
Copy link
Collaborator

jzohrab commented Jun 13, 2024

Thanks @bwkimmel - this is the behaviour as currently designed (i.e., the search just does a big text search on several fields), but as you've noted, it's a bad design.

It is going to need #429 implemented, or something close to it, to solve this properly. I've never been bothered enough by it, but I agree it's not super great the way it is. Thanks for taking the time to create the issue. 👋

@jzohrab jzohrab added bug Something isn't working blocked labels Jun 13, 2024
@jzohrab jzohrab changed the title Term lists linked from the "term tags" page lists words without that tag Term lists linked from the "term tags" page lists words without that tag - blocked by 429 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants