Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change audio file #467

Open
jamesdeluk opened this issue Aug 14, 2024 · 2 comments
Open

Change audio file #467

jamesdeluk opened this issue Aug 14, 2024 · 2 comments
Labels
tweak Adjustment to the code -- not a new feature, just minor mods/tweaks

Comments

@jamesdeluk
Copy link

Is your feature request related to a problem? Please describe.

Be able to change the audio file after a book has been created.

Describe the solution you'd like

For example, under the Edit side menu, a "Change audio" option.

Describe alternatives you've considered

Changing the audio file directly in the storage, but this can alter the audio player tracking bar (i.e. if you replace a 2min audio clip with a 1min clip, and click 1m30s, it fails - you have to reload the page).

Additional context

If the duration was recalculated based on the audio file found, this could be a workaround.

@jzohrab
Copy link
Collaborator

jzohrab commented Aug 15, 2024

Thanks @jamesdeluk - I didn't include it initially because

  • a) I didn't need it :-)
  • b) any existing audio bookmarks would potentially be incorrect with a new audio file. I guess that replacing the file would kill all of the old audio bookmarks, we could add a warning to the form.

But yes, this should be added. If you have a different idea for handling the audio bookmarks, let me know -- the only other option I can think of is to leave them all as-is and have the user fix them, but that could be tedious too.

@jzohrab jzohrab added the tweak Adjustment to the code -- not a new feature, just minor mods/tweaks label Aug 15, 2024
@jamesdeluk
Copy link
Author

I don't typically use bookmarks, so I hadn't considered that.

I feel that if a user is replacing the audio they should realise bookmarks may not auto-sync, so I feel a warning would suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tweak Adjustment to the code -- not a new feature, just minor mods/tweaks
Projects
Status: No status
Development

No branches or pull requests

2 participants