Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoMakieDimensionalDataExt #269

Open
asinghvi17 opened this issue Sep 1, 2024 · 1 comment
Open

GeoMakieDimensionalDataExt #269

asinghvi17 opened this issue Sep 1, 2024 · 1 comment

Comments

@asinghvi17
Copy link
Member

We need to ensure that any dimensional arrays have range like lookups before we allow meshimage...if they don't we can throw an informative error redirecting the user to surface.

@rafaqz you may want to do the same for image in DD...

@rafaqz
Copy link

rafaqz commented Sep 1, 2024

Not necessarily holding ranges... But Regular spans. We don't swap regular vectors to ranges to avoid the floating point changes. (Also for performance in some cases, reading a vector is faster than steprange extended float calculations)

But yes I wonder if an error or a warning is best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants