Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 Page #42

Open
rodolfomartinez opened this issue Apr 14, 2019 · 6 comments
Open

404 Page #42

rodolfomartinez opened this issue Apr 14, 2019 · 6 comments
Assignees
@bartmika @rodolfomartinez @hnamdev008
Labels
bug Something isn't working

Comments

@rodolfomartinez
Copy link

Summary:
Is it possible to change the content layout so that it is two columns
Column 1 should be the icon and the explanation text
Column 2 should start with the phone URL

Both columns should be scaled so that on an iPad w retina (2048x1536) both columns fit on one screen w no scrolling
@rodolfomartinez rodolfomartinez added the bug Something isn't working label Apr 14, 2019
@bartmika
Copy link
Member

@rodolfomartinez Can you confirm latest code fixes this issue?

@hnamdev008
Copy link
Collaborator

@rodolfomartinez
I am still waiting for your sketch layout of this page, it can be rough layout of the elements.

hnamdev008 pushed a commit that referenced this issue Apr 23, 2019
#42, #43 - error pages 404, 500 are fixed as Rodofo required
fcdb6a8
@hnamdev008
Copy link
Collaborator

@bartmika
Please merge for this so Rodolfo check it out, thanks!

@rodolfomartinez
I have implemented 404, 500 pages as you required.
thanks.

bartmika added a commit that referenced this issue Apr 23, 2019
@bartmika
Merge pull request #55 from MikaSoftware/#42,#43
d585f83 
#42,#43
@bartmika
Copy link
Member

@soyong20161205 I spoke with Rodolfo and we decided the follow:

  • Revert back to the original design
  • Adjust the size so if we look at this page from an iPhone then it will scale properly to fit everything on a single page.

@hnamdev008
Copy link
Collaborator

@rodolfomartinez
Can you come online on skype so I need to discuss things with you?

hnamdev008 pushed a commit that referenced this issue Apr 24, 2019
#42, #43, #56 - all size-relevant issues fixed
e1cca1f
@hnamdev008 hnamdev008 mentioned this issue Apr 24, 2019
Merged
bartmika added a commit that referenced this issue Apr 26, 2019
@bartmika
Merge pull request #61 from MikaSoftware/#56,#43,#42
f4af0c6 
#42, #43, #56 - all size-relevant issues fixed
@bartmika
Copy link
Member

@rodolfomartinez Can you confirm the design is acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartmika bartmika

@rodolfomartinez rodolfomartinez

@hnamdev008 hnamdev008

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bartmika @rodolfomartinez @hnamdev008