Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player class should be able to represent arbitrary player not necessarily present #30

Open
WalkerY opened this issue Jun 24, 2015 · 1 comment

Comments

@WalkerY
Copy link

WalkerY commented Jun 24, 2015

it raises exception:
except NonexistentPlayerError:
self.__invalidate("Tried to initialize a Player instance of a nonexistant player.")

but its needed to represent player that is not on server, for future-proof implementations for example all functions should pass Player instances instead of names. Behind the scenes, in methods like 'getelo' player instance could be used of the player that exists but is not necessarily on server and whose lets say steam id was found in some other way.

@WalkerY
Copy link
Author

WalkerY commented Jun 25, 2015

Ok, i guess dummyplayer can be used in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant