Use only the debug settings from the most-downstream Swift target #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents settings which are specific to a particular Swift module compilation, such as clang module maps in a mixed-language library, from getting accumulated with the public settings. Before this change using `mixed_language_library` would result in module redefinition errors in lldb. I’m not sure if this has a chance of not setting some flags that would need to be set. In local testing everything worked, but as with all things lldb, wider user testing is needed. Ideally long term we can use serialized debug info instead (and/or explicit modules). Signed-off-by: Brentley Jones <[email protected]>
thiagohmcruz
approved these changes
Aug 15, 2024
tools/generators/target_build_settings/src/Generator/ProcessSwiftArgs.swift
Show resolved
Hide resolved
|
Found an issue with the current way this is done, but have a plan to fix it. Going to work on that before merging. |
Signed-off-by: Brentley Jones <[email protected]>
|
Added a note instead since a proper fix is too hard/inefficent. |
brentleyjones
deleted the
bj/use-only-the-debug-settings-from-the-most-downstream-swift-target
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents settings which are specific to a particular Swift module compilation, such as clang module maps in a mixed-language library, from getting accumulated with the public settings. Before this change using
mixed_language_librarywould result in module redefinition errors in lldb.I’m not sure if this has a chance of not setting some flags that would need to be set. In local testing everything worked, but as with all things lldb, wider user testing is needed. Ideally long term we can use serialized debug info instead (and/or explicit modules).
Note: For this to work the best, the single dep of a top-level target needs to be a
swift_libraryormixed_language_target. This change might result in lldb regressions for custom setups that don't meet that requirement.