poc: add support for locations.geojson (use feature collection as entities) #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamez
added
the
do not merge
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8dccf0a 📊 Notices ComparisonNew Errors (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1564 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit c135b3c 📊 Notices ComparisonNew Errors (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1564 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
davidgamez
changed the title
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit cb2d613 📊 Notices ComparisonNew Errors (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (49 out of 1564 datasets, ~3%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
New Warnings (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (760 out of 1564 datasets, ~49%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1564 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
This was
linked to
issues
Aug 29, 2024
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f63a52a 📊 Notices ComparisonNew Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
5 tasks
bdferris-v2
reviewed
Sep 4, 2024
core/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsDescriptor.java
Show resolved
Hide resolved
bdferris-v2
reviewed
Sep 4, 2024
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| public abstract class GtfsContainer<T extends GtfsEntity, D extends GtfsDescriptor> { |
There was a problem hiding this comment.
Consider naming this GtfsEntityContainer to distinguish it from the GtfsFeedContainer type?
5 tasks
|
I am closing this PR in favor of #1810. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is in Work in Progress state, the only reason is marked as Ready For Review is to make it easier to run the set of acceptance tests(acceptance tests are skipped for draft PRs).
Major changes introduced in this PR:
Still missing:
Optimization:
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything