Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Key Validation #217

Open
1 of 3 tasks
Ferrisx4 opened this issue Sep 19, 2019 · 1 comment
Open
1 of 3 tasks

API Key Validation #217

Ferrisx4 opened this issue Sep 19, 2019 · 1 comment
Assignees
@Ferrisx4
Labels
enhancement New feature or request

Comments

@Ferrisx4
Copy link
Contributor

Ferrisx4 commented Sep 19, 2019 •
edited
Loading

If the module attempts to use an invalid API key, the import will fail.

  • If API key is rejected by NCBI, try to import anyway (NCBI doesn't require API keys, it just allows higher rate)
  • Warnings to the user
  • Validate API key at administration screen before saving

It would also be nice to be able to validate the API key before attempting an import (either by querying NCBI directly or checking for allowed patterns). Unfortunately NCBI's API key documentation doesn't seem to list what form their API keys will always adhere to.
@Ferrisx4 Ferrisx4 added the enhancement New feature or request label Sep 19, 2019
@Ferrisx4 Ferrisx4 self-assigned this Sep 19, 2019
@Ferrisx4
Copy link
Contributor Author

Ferrisx4 commented Oct 3, 2019

Probably related to #218 to some degree.

At any rate, better validation of NCBI's response is needed (beyond erroneous API key issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ferrisx4 Ferrisx4

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ferrisx4