-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIR column - Registro.BR - No matching to some blocks #308
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
My IPv4 prefixes are also like this, only the IPv6 ones are correct |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
I think it's clear we need to look into this. Posting "Me too" messages without any details doesn't add any value, no need to do that. And from what I see, I don't think we need more examples to check what's wrong here. |
Sorry dude! My bad! |
I do not see an obvious cause in the code. I added this in #231, which reads https://ftp.registro.br/pub/numeracao/origin/nicbr-asn-blk-latest.txt. 143.208.160.0/22 is in there, for example. |
@mxsasha _rir_for_prefix function in api/collectors.py looks for the prefix and returns the first ocurrence of it, right? Since the same prefix appears in lacnic (https://ftp.lacnic.net/pub/stats/lacnic/delegated-lacnic-latest as lacnic|BR|ipv4|143.208.160.0|1024|20151113|assigned) but also in registro.br, it seems that the lacnic RIR appears first. Perhaps a simple fix should be to change the RIR class and put registro.br before lacnic in state.py |
Yes, that would explain it. I did not expect an exact match prefix to occur in multiple "RIRs". Not entirely sure of the right fix, the return order from the query is arbitrary, maybe the code should look at all rows and decide the "most specific RIR". |
I was thinking a little about this question this morning, and a hypothesis came to mind. In fact, a very boring hypothesis. Shouldn't the RIR attribute be able to be multivalued? An array or something? I thought about this considering how the numeric resource assignment hierarchy is in the real world. RIRs, NIRs, LIRs. A prefix that is assigned by Registro.BR actually is ALSO a "child" of LACNIC. I know it's not the focus of IRR-Explorer to address these intricacies. |
@fischerdouglas I was also thinking about it, but as I understand it, there's 3 distinct "levels" and it doenst really matter whos is child of who, because a prefix should never belong to more than one register at the same level. So we just need a list or a attribute that identifies that. My first approach would be to just create a NIR array. If a prefix appears on more than one register, look for the one in the NIR array. |
Some friends reported some issues on the RIR source.
I used an ASN of a university just to exemplify the issue.
https://irrexplorer.nlnog.net/asn/AS53046
The text was updated successfully, but these errors were encountered: