Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple CeilingFan elements #1819

Open
shorowit opened this issue Aug 30, 2024 · 1 comment
Open

Allow multiple CeilingFan elements #1819

shorowit opened this issue Aug 30, 2024 · 1 comment
Labels
enhancement New feature or request priority low

Comments

@shorowit
Copy link
Contributor

Only one CeilingFan element is allowed:

<sch:assert role='ERROR' test='count(h:Lighting/h:CeilingFan) &lt;= 1'>Expected 0 or 1 element(s) for xpath: Lighting/CeilingFan</sch:assert> <!-- See [CeilingFan] -->

The element can represent multiple ceiling fans via the Count element, but you cannot specify differernt ceiling fans with different types.

We might have decided to only support a single element because of the defaulting logic, where we default the the total number of ceiling fans in the house (i.e, Count = NumberofBedrooms + 1). If there are multiple CeilingFan elements with the Count specified, how would we default them?

@joseph-robertson

@shorowit shorowit added the enhancement New feature or request label Aug 30, 2024
@shorowit
Copy link
Contributor Author

Maybe we could require Count only when there are multiple ceiling fans.

Or maybe we should require Count always (though it'd be a breaking change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority low
Projects
Status: Backlog
Development

No branches or pull requests

1 participant