Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse dependency on wrong variable #18

Closed
DeadParrot opened this issue Sep 3, 2021 · 3 comments
Closed

Reverse dependency on wrong variable #18

DeadParrot opened this issue Sep 3, 2021 · 3 comments
Labels
bug Something isn't working OCT OPTIMICA Compiler Toolkit QSS Quantized State System
Milestone

Comments

@DeadParrot
Copy link
Collaborator

The OCT FMU generated for the DepTest model has two event indicator when blocks, the first block modifies a local variable, l, given index 46 and the second modifies an output variable, o, given index 47. The current OCT short-circuits local variables out of reverse dependencies so I would expect to get:

			<EventIndicators>
				<Element index="11" reverseDependencies=""/>
				<Element index="12" reverseDependencies="47"/>
			</EventIndicators>

but what appears is:

			<EventIndicators>
				<Element index="11" reverseDependencies="47"/>
				<Element index="12" reverseDependencies="47"/>
			</EventIndicators>

showing a reverse dependency of the first event indicator on a variable that its block does not modify.

@DeadParrot
Copy link
Collaborator Author

Versions

The issue was observed with these component versions (may occur with others):

Component Version Date
OCT OCT-r23206_JM-r14295 2021/05
Buildings 9c37781 2021/05/04
QSS e4a0f62 2021/06/08

Build

Build the FMU with bld from the OCT directory as described in the Status page.

The dependencies can be examined in the modelDescription.xml file.

@DeadParrot DeadParrot added bug Something isn't working OCT OPTIMICA Compiler Toolkit QSS Quantized State System labels Sep 3, 2021
@DeadParrot DeadParrot added this to the 0.0.1 milestone Sep 3, 2021
@DeadParrot
Copy link
Collaborator Author

Based on information from Modelon, this behavior is as currently designed. All variables modified within any conditional block within the same algorithm section are made reverse dependencies of any event indicator within that section. That effectively makes this overlap issue #10: the improvement for this would be to make the reverse dependencies specific to their event indicators and that will also correct the array reverse dependency issue seen with the ACControl10 model.

@DeadParrot
Copy link
Collaborator Author

This issue has been made moot by the addition of an OCT FMU build option that generates a <Dependencies> annotation section that provides the full dependencies that QSS needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OCT OPTIMICA Compiler Toolkit QSS Quantized State System
Projects
None yet
Development

No branches or pull requests

1 participant