New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

90.1 PRM: Disable self-shading #1525

Open

eringold opened this issue Jun 4, 2023 · 0 comments

Labels

AppendixG

Collaborator

eringold commented Jun 4, 2023 •

edited

Loading

This TODO in model_create_prm_any_baseline_building:

openstudio-standards/lib/openstudio-standards/standards/Standards.Model.rb

Lines 441 to 443 in d332605

    
           # @todo: turn off self shading 
        
           # Set Solar Distribution to MinimalShadowing... problem is when you also have detached shading such as surrounding buildings etc 
        
           # It won't be taken into account, while it should: only self shading from the building itself should be turned off but to my knowledge there isn't a way to do this in E+

is now be possible via NREL/EnergyPlus#6390 and NREL/OpenStudio#3913

sc = model.getShadowCalculation
sc.setDisableSelfShadingWithinShadingZoneGroups(true)
sc.setDisableSelfShadingFromShadingZoneGroupstoOtherZones(true)

The text was updated successfully, but these errors were encountered:

lymereJ added the AppendixG label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment