Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1 writing _uncalibrated.mzML for RAW files #327

Open
chambm opened this issue Jul 30, 2024 · 7 comments
Open

4.1 writing _uncalibrated.mzML for RAW files #327

chambm opened this issue Jul 30, 2024 · 7 comments
Assignees

Comments

@chambm
Copy link

chambm commented Jul 30, 2024

I'm doing a data_type=2 GPF search. Is it supposed to always write the uncalibrated mzML even though I have:
write_calibrated_mzml = 0
write_uncalibrated_mgf = 0

@fcyu fcyu self-assigned this Jul 30, 2024
@fcyu
Copy link
Member

fcyu commented Jul 30, 2024

It always write the *_uncalibrated.mzML if the input is in .raw and .d because some downstream tools can't read them.

Best,

Fengchao

@chambm
Copy link
Author

chambm commented Jul 30, 2024

Can you make that an option? Not only are those files big but BiblioSpec currently prefers _uncalibrated.mzML over .RAW, even though it's capable of reading RAW. In this case for performance and space-savings we'd would want to prefer RAW. It would be easiest to achieve that by just not making the mzML in the first place, but in the short term I can just delete it before running BlibBuild.

@fcyu
Copy link
Member

fcyu commented Jul 30, 2024

TBH, I don't want to add this option. We had this option before if I remembered it correctly, but there were just too many options, and we always need _uncalibrated.mzML with raw as input.

Best,

Fengchao

@chambm
Copy link
Author

chambm commented Jul 30, 2024

No problem, I can just the delete the files. I feel like since it's in the same vein as the other two options it would fit right in and it doesn't matter if there's 120 options or 121 options. :)

@chambm chambm closed this as completed Jul 30, 2024
@chambm
Copy link
Author

chambm commented Jul 30, 2024

Wait what happens if the RAW location is read-only? Does it error or just skip the writing?

@fcyu
Copy link
Member

fcyu commented Jul 30, 2024

That's correct, it prints something like Could not write XXX_uncalibrated.mzML. It will not affect MSFragger's result..

And I agree that it will be an issue because MSFragger also writes *.pepXML and *.pin files to that directory. I always want to change MSFragger to write the files to the result folder, but don't have time to do that.

Best,

Fengchao

@fcyu
Copy link
Member

fcyu commented Aug 17, 2024

Hi Matt,

After a second thought, I decided to add the write_uncalibrated_mzml and removed the write_uncalibrated_mgf that is used nowhere. Let me know if you want to test the new version. Maybe can wait until #324 is also done.

Best,

Fengchao

@fcyu fcyu reopened this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants