Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookies to store current instance #20

Open
viv9k opened this issue Jun 8, 2020 · 1 comment · Fixed by #22
Open

Add cookies to store current instance #20

viv9k opened this issue Jun 8, 2020 · 1 comment · Fixed by #22
Labels
bug Something isn't working Feature New feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@viv9k
Copy link
Collaborator

viv9k commented Jun 8, 2020

Current functionality

Currently user are not taken can by the browser, which may lead to some error with reloading the current instance of master or participants

Required Feature

Enable the browser cookies to keep track of master and participants session so that even when the page reloads or connectivity problem occurs the session is not lost things are working properly.

@viv9k viv9k added bug Something isn't working Feature New feature help wanted Extra attention is needed good first issue Good for newcomers labels Jun 8, 2020
@viv9k
Copy link
Collaborator Author

viv9k commented Jun 20, 2020

I have added cookie npm module which is best and latest ngx-cookie-service . This can be further used to store cookies.

Introduce a new service that handles all the cookie from one place and that will be very good option if we plan to have more cookies in future.

Component Logging and Header is already using the cookie service. Upto basic level.

@viv9k viv9k linked a pull request Jun 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feature New feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant