Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code detecting changes in addons #154

Open
sbidoul opened this issue Aug 14, 2021 · 2 comments
Open

Refactor code detecting changes in addons #154

sbidoul opened this issue Aug 14, 2021 · 2 comments
Labels
Bot Framework Related to the bot framework enhancement New feature or request

Comments

@sbidoul
Copy link
Member

sbidoul commented Aug 14, 2021

Several tasks want to act when pull requests add new addons or change existing addons.

We could simplify the code and make it easier to test by having a main tasks that does the delicate work of detecting addon changes and the call registered actions, passing the new/changed manifests.
@sbidoul sbidoul added enhancement New feature or request Bot Framework Related to the bot framework labels Aug 14, 2021
@sbidoul
Copy link
Member Author

sbidoul commented Aug 16, 2021

The core "diff" feature could be in manifestoo.

@len-foss
Copy link

len-foss commented Dec 30, 2021 •
edited
Loading

These features are implemented in acsone/manifestoo#19 and acsone/manifestoo#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bot Framework Related to the bot framework enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbidoul @len-foss