Fixed #1206 - Weather View Visibility

[amrhossamdev]

Fixes #1206.

Control the state of the weather view when switching the fragment from the nav drawer

Video

Screencast.from.04-26-2024.04.07.52.PM.webm

• Apply the AndroidStyle.xml style template to your code in Android Studio.

• Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

[aaronbrethorst]

I recommend always trying to figure out how to reduce the amount of nesting that occurs from control flow within a method. I would recommend writing this method like this:

• Check whether weatherView is null or not, and return early if it is.
• DRY up the call to weatherView.setVisibility() by determining visibility with a ternary expression.

public static void toggleWeatherViewVisibility(boolean shouldShow, View weatherView) {
  (if weatherView == null) {
    return;
  }
  
  weatherView.setVisibility(shouldShow ? View.VISIBLE : View.GONE);
}

[amrhossamdev]

Much better I will refactor it

[aaronbrethorst]

👍 looks good! thanks for thinking about this from the user's perspective and getting it fixed!