Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get maintained #27

Closed
wolneykien opened this issue Aug 18, 2017 · 9 comments
Closed

Get maintained #27

wolneykien opened this issue Aug 18, 2017 · 9 comments

Comments

@wolneykien
Copy link
Contributor

Hi Ludovic!

I currently maintain the package in Sisyphus and already have a number of patches I want to integrate. If you're really looking for a new maintainer, I can take it over.

@LudovicRousseau
Copy link
Member

Sorry I don't think I noticed your proposal before.
Do you still volunteer to maintain pam_pkcs11?

@wolneykien
Copy link
Contributor Author

Hi! Probably, yes.

I've made a special version for Sisyphus with many new configuration options, configurable prompts, and low-level modules (a card-specific implementation to get an exact number of PIN attempts, for instance).

However, I don't think all of that is really needed in the mainstream pam_pkcs11 project. So, what are the criteria of updating / maintaining the mainstream version?

@LudovicRousseau
Copy link
Member

I just sent you an invitation to join the "pam_pkcs11 maintainers" group.

It is now up to you to decide what you want to do with pam_pkcs11 :-)
You can even include card specific code. Maybe with the possibility to disable it or not enable it by default.

@frankmorgner
Copy link
Member

@wolneykien please create a new release, because there were some security issues discovered (https://www.x41-dsec.de/lab/advisories/x41-2018-003-pam_pkcs11/). I've fixed all of them upstream, but I'll leave the testing, packaging and write up of some release notes to you. Maybe you also want to cherry-pick some of your more generic changes.

@wolneykien
Copy link
Contributor Author

Thanks, Frank! Where are these security fixes for now?

@frankmorgner
Copy link
Member

they are available as commits in master

@wolneykien
Copy link
Contributor Author

Hi, guys! Note the #48 issue!

@LudovicRousseau
Copy link
Member

@frankmorgner I see nothing new in master since the 0.6.11 release I made in May 2019.
I guess the commits your are talking about are already present in release 0.6.11.
If that is not the case then please be more specific.

@LudovicRousseau
Copy link
Member

@wolneykien I propose you to create Pull Requests with your changes rebased on the current master. Since you created different branches it should be easy to create different PR. Of course the order is important since some patches depend on other ones.

If nobody complains after some days you can merge/apply them yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants