Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-reviewer workflow needs revisiting #351

Open
dasaderi opened this issue May 3, 2021 · 3 comments
Open

Co-reviewer workflow needs revisiting #351

dasaderi opened this issue May 3, 2021 · 3 comments

Comments

@dasaderi
Copy link
Member

dasaderi commented May 3, 2021

Testing the add co-reviewer workflow on dev site, I noticed a few things:

  • I was able to add my anonymous persona as co-reviewer. Should this be possible?
  • When I went to check user drafts, I saw that there was a message asking me to accept the invitation. I wonder how would a user know what persona they are asked to join the draft with. Will it default to the active persona? If the user changes that active persona, will they be able to be co-reviewers with the newly selected one or will they have to be added again? What if I accept the invitation and then decide to be removed as an author?
@dasaderi dasaderi added the question Further information is requested label May 3, 2021
@dasaderi
Copy link
Member Author

dasaderi commented May 3, 2021

Also, again on dev site, when I declined the invitation (as I added my other persona as co-reviewer) I got this message
Screen Shot 2021-05-03 at 2 45 34 PM

But I can accept it
Screen Shot 2021-05-03 at 2 46 46 PM

@dasaderi
Copy link
Member Author

Check this workflow works.

@dasaderi dasaderi added medium priority and removed question Further information is requested labels Jul 15, 2021
@dasaderi dasaderi changed the title Add co-reviewer workflow - manage personas when adding co-reviewer and accepting it Co-reviewer workflow needs revisiting Sep 28, 2021
@dasaderi
Copy link
Member Author

Because of the multiple issues related to this workflow, we want to list here how it should work:

  • A user fills out a rapid PREreview with one persona
  • Then with the same persona, that user starts a full PREreview
  • The user saves the full PREreview draft
  • The draft is saved in their user drafts page so that it can be accessed later - making sure that it is clear to the user if the draft is associated with one or the other persona (connected to issue Add the personas toggle to the User Drafts page #411)
  • When user clicks on user draft they get sent to the full PREreview editor with the draft loaded (see issue Draft not showing in "User Drafts" #353 about drafts not currently showing up)
  • User invites a co-reviewer and/or a mentor to write a full PREreview
  • The invited co-reviewer or mentor gets an email with a link that goes to the user draft page (see issue Change the subject title for full PREreview draft invites #412 and Update the full PREreview invite to co-review email #413 related to email invitation)
  • There they are prompted to accept or decline the invitation
  • If they accept and they have already filled out a rapid PREreview, when they click on the draft they are brought directly to the full PREreview draft where they can see the other co-reviewers as their avatars show up at the top (issue Make the co-reviewer's avatars visible after they've accepted their invite #414)
  • If they accept and they have NOT yet filled out a rapid PREreview, when they click on the draft they are brought to the rapid PREreview form first. Once they fill that out they are automatically brought to the full PREreview draft OR they have to still answer yes to the question of wanting to fill out a full PREreview and when they say yes, they see the draft and who else is co-reviewing with them.
  • When two co-reviewers are on the same draft, they should see each other but only one at the time can make and save changes -- THIS NEEDS DISCUSSION ON HOW IT WOULD WORK - it needs to be signaled to the user that that draft is not available for editing at the moment as the other co-reviewer is editing.
  • The submit button should be only an option available to the person who started the full PREreview - THIS ALSO NEEDS DISCUSSION
  • BUT submission is not completed until every co-reviewers has accepted the final draft - this option is NOT there at the moment and needs discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant