You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it's expected that after the PlayerQuitEvent for the player to not tick anymore, which could potentially create issues with plugins that rely on the data state of the player in the context of the player quit. Making it impossible for the player to naturally take "damage" from sources like fire tick etc.
Observed/Actual behavior
Currently, I believe this is a Spigot tick, not sure, the code runs the player quit alongside a disconnect with the reason, and ticks the player after this event. meaning if any plugin relies on .isDead(), or other sorts of data that changed exactly after the context of player quit, would be basically an outdated data.
Steps/models to reproduce
It's in the code base, call player quit, then tick the player. This causes an issue, for example if a plugin relies on .getINventory(), and on the .doTick() the player dies, takes damage, the plugin would be having outdated data, it's at least an understanding that the player quit is basically saying "nothing will further happen to this user"
The code that causes the issue:
I know this technically was a spigot addon, but thought I could just report and maybe paper decides, or maybe even has an explanation as to why this wouldn't change if so? :)
Plugin and Datapack List
0
Paper version
latest commit, it's just to fork and see the method.
Other
No response
The text was updated successfully, but these errors were encountered:
Expected behavior
I think it's expected that after the PlayerQuitEvent for the player to not tick anymore, which could potentially create issues with plugins that rely on the data state of the player in the context of the player quit. Making it impossible for the player to naturally take "damage" from sources like fire tick etc.
Observed/Actual behavior
Currently, I believe this is a Spigot tick, not sure, the code runs the player quit alongside a disconnect with the reason, and ticks the player after this event. meaning if any plugin relies on .isDead(), or other sorts of data that changed exactly after the context of player quit, would be basically an outdated data.
Steps/models to reproduce
It's in the code base, call player quit, then tick the player. This causes an issue, for example if a plugin relies on .getINventory(), and on the .doTick() the player dies, takes damage, the plugin would be having outdated data, it's at least an understanding that the player quit is basically saying "nothing will further happen to this user"
The code that causes the issue:
I know this technically was a spigot addon, but thought I could just report and maybe paper decides, or maybe even has an explanation as to why this wouldn't change if so? :)
Plugin and Datapack List
0
Paper version
latest commit, it's just to fork and see the method.
Other
No response
The text was updated successfully, but these errors were encountered: