Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute modifiers don't reset after death 1.21.1 #11467

Open
FurrO2 opened this issue Oct 3, 2024 · 2 comments
Open

Attribute modifiers don't reset after death 1.21.1 #11467

FurrO2 opened this issue Oct 3, 2024 · 2 comments
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. upstream: spigot Issues exists in Spigot. version: 1.21.1

Comments

@FurrO2
Copy link

FurrO2 commented Oct 3, 2024

Expected behavior

  1. the player have an attribute ( like this one for exemple : /attribute @p minecraft:generic.max_health modifier add 1 10 add_value
  2. the player died
  3. the attribute is reset because in this case, the attribute is not the Base attribute

here an exemple of vanilla 1.21.1

https://youtu.be/hHGpRTtGZJA

Observed/Actual behavior

  1. the player have an attribute ( like this one for exemple : /attribute @p minecraft:generic.max_health modifier add 1 10 add_value
  2. the player died
  3. the attribute still active ( and somes plugins are affected by that )

Steps/models to reproduce

how to make the bug:

  1. do that command: /attribute @p minecraft:generic.max_health modifier add 1 10 add_value
  2. play in gamemode survival and do some /kill @p
  3. the generic.max_health modifier is not reset and that is the bug

Plugin and Datapack List

no plugins

Paper version

This server is running Paper version 1.21.1-119-master@7cd4f2c (2024-10-03T15:19:34Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)

Other

No response

@FurrO2 FurrO2 added status: needs triage type: bug Something doesn't work as it was intended to. labels Oct 3, 2024
@FurrO2 FurrO2 changed the title Attribute don't reset after death 1.21.1 Attribute modifiers don't reset after death 1.21.1 Oct 3, 2024
@masmc05
Copy link
Contributor

masmc05 commented Oct 3, 2024

Worth mentioning, 24w20a fixed base values not being copied on death, attribute modifiers should still be reset on death to be like in vanilla

@electronicboy
Copy link
Member

electronicboy commented Oct 3, 2024

https://minecraft.wiki/w/Java_Edition_24w33a 1.21.2 snapshot, also changes this further...
actually, this is a non factor, this only affects living respawns, something spigot basically opted us out of

@Lulu13022002 Lulu13022002 added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. upstream: spigot Issues exists in Spigot. and removed status: needs triage labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. upstream: spigot Issues exists in Spigot. version: 1.21.1
Projects
Status: ✅ Accepted
Development

No branches or pull requests

4 participants