What to do with the compiler warnings?

[PaulRBerg]

This may be an issue with Solidity v0.8.1 in particular.

Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:75:5:
   |
75 |     function div(uint256 x, uint256 y) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:95:5:
   |
95 |     function exp(uint256 x) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:347:5:
    |
347 |     function log2(uint256 x) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:388:5:
    |
388 |     function mul(uint256 x, uint256 y) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:75:5:
   |
75 |     function div(uint256 x, uint256 y) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:95:5:
   |
95 |     function exp(uint256 x) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:347:5:
    |
347 |     function log2(uint256 x) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:388:5:
    |
388 |     function mul(uint256 x, uint256 y) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:75:5:
   |
75 |     function div(uint256 x, uint256 y) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:95:5:
   |
95 |     function exp(uint256 x) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:347:5:
    |
347 |     function log2(uint256 x) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:388:5:
    |
388 |     function mul(uint256 x, uint256 y) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:75:5:
   |
75 |     function div(uint256 x, uint256 y) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
  --> prb-math/contracts/PRBMathUD60x18.sol:95:5:
   |
95 |     function exp(uint256 x) internal pure returns (uint256 result) {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:347:5:
    |
347 |     function log2(uint256 x) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Variable is shadowed in inline assembly by an instruction of the same name
   --> prb-math/contracts/PRBMathUD60x18.sol:388:5:
    |
388 |     function mul(uint256 x, uint256 y) internal pure returns (uint256 result) {
    |     ^ (Relevant source part starts here and spans across multiple lines).
    ````

[AlbertSu123]

I can confirm that 0.8.4 has the same issues as well. This makes sense since the assembly instructions for ethereum don't change and they do shadow these functions.

To the best of my knowledge you are free to ignore them as of now, the warnings just make it annoying to see real warnings.

[PaulRBerg]

Hmm, okay. I'll see what I can do about this.

[AlbertSu123]

As a user of the library, I wouldn't mind it at all if you renamed all operations to their full names, ie mul -> multiply, add -> addition

[cameel]

These warnings were actually fixed in 0.8.2: ethereum/solidity#10971

[PaulRBerg]

Interesting. Could you post another reply to this thread as an answer instead of a comment, @cameel? I will accept that as the solution and lock this discussion.

[cameel]

Sure.

[PaulRBerg]

I wonder if Solidity v0.8.5 solves this .. as per the release changelog:

Name Resolver: Do not issue shadowing warning if the shadowing name is not directly accessible.

As far as I know, top-level functions cannot be accessed from within yul.

[cameel]

These warnings were suppressed in 0.8.2: ethereum/solidity#10971. They were not adding any value because, while these things are indeed shadowed, you can't really call them from inline assembly so no point warning about it.

I wonder if Solidity v0.8.5 solves this

The changelog entry from 0.8.5 was about a slightly different situation. This one was listed in 0.8.2 release notes:

Inline Assembly: Do not warn anymore about variables or functions being shadowed by EVM opcodes.