Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link at getpelican/pelican-themes to point to the latest release #281

Closed
silverhook opened this issue Mar 21, 2019 · 11 comments
Closed

Comments

@silverhook
Copy link
Member

Currently https://github.com/getpelican/pelican-themes points to a 4-year-old release. We should let them know to point to the newest release – or better yet, directly to master, as we now treat that as a stable branch.

@iranzo
Copy link
Member

iranzo commented Apr 16, 2019

@iranzo
Copy link
Member

iranzo commented Apr 16, 2019

Will be closed by getpelican/pelican-themes#643

@talha131 talha131 added this to the 2019 - Q2 milestone Jun 17, 2019
@iranzo
Copy link
Member

iranzo commented Jun 27, 2019

Will be closed by getpelican/pelican-themes#643

This is already merged in pelican, closing

@iranzo iranzo closed this as completed Jun 27, 2019
@talha131
Copy link
Member

Here's the issue. Whenever we do a release, we will have to update the pelican-themes repo. Because submodules track commits. We can't make submodules to always track the latest tag or master.

So what can we do here? Have a travis task to automatically open a PR?

This is important because Pelican-Themes repository is one of the biggest source of Elegant discovery, or at least the first place new users look for a theme.

What can we do here?

@talha131 talha131 reopened this Jun 27, 2019
@iranzo
Copy link
Member

iranzo commented Jun 27, 2019

It should be pelican repo to automatically/periodically run git submodules update on their end....

@talha131
Copy link
Member

Well we have little control on Pelican repo. Can we make a travis task for automatically opening the PR?

I have seen such bots for JS. They open PR if a dependency used in your project has a latest release.

Can we have such bot to open PR on their repo?

@iranzo
Copy link
Member

iranzo commented Jun 27, 2019

I was checking PR for something at work and it's not 'easy' as it requires using 'hub' cli which requires authentication.

If we've some contact like Justin, we can reach, it would be great to add basic travis checks on their side and even consider creating a regular job to update submodules, I'll open issue to them too

@iranzo
Copy link
Member

iranzo commented Jun 27, 2019

@talha131
Copy link
Member

Good job. Lets see what they have to say.

@iranzo
Copy link
Member

iranzo commented Jun 27, 2019

thanks!

@talha131 talha131 modified the milestones: 2019 - Q2, 2019 - Q3 Jun 30, 2019
@talha131
Copy link
Member

We have opened up PR in pelican themes repo. There isn't much we can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants