osrm-extract command with run-time error on Windows OS

[tommybee-dev]

Discussed in #6932

^{Originally posted by tommybee-dev June 8, 2024}
Hi, I am new to OSM back-end.
Recently I've built this project with MSVC 2022 Express.
I've downloaded a pb file frome here.

I've got a runtime error at near by 'next' function since running osrm-extract.exe with the file I downloaded.

osrm-extract data/south-korea-latest.osm.pbf

Here is what I am traced the code from file restriction_graph.cpp.

I don't know how to handle these error.
Thanks.

[tommybee-dev]

Hi,
Finally, I found the point where the access violation from since I am trying to dig the code in the restriction_graph.cpp.

// Also add any restric
 // tions from suffix paths to the current node in the
 // restriction graph.
 for (const auto &restriction : rg.GetRestrictions(suffix_node))
 {
     insertRestriction(rg, cur_node, restriction);
 }

I changed the original code in the next function above as followed:

// Also add any restric
// tions from suffix paths to the current node in the
// restriction graph.
RestrictionGraph::RestrictionRange range1 = rg.GetRestrictions(suffix_node);

for (int i = 0; i < range1.size(); i++)
{
	const auto &restriction = range1[i];
	insertRestriction(rg, cur_node, restriction);
}

I think the problem is clear that the range has the same memory begin and end.
But I still don't know why this problem gonna happened.

Anyone can get me go further will be appreciated.

Thanks.

[mrquangbadao]

Hi Mr @tommybee-dev, I am Quang, your friend here.
I applied your solution to the code snippet above and testing it using unit test (using extractor-tests.exe). It’s great news that these block code no longer has errors!
However, I noticed another error starting from line 150 in the restriction_graph.cpp file, which had the same root cause as the previous code.
I used your solution to fix this code snippet as well, modifying the code
From:

for (const auto &suffix_edge : rg.GetEdges(suffix_node)) {
    if (suffix_edge.is_transfer) {
        continue;
    }
//other code

To:

RestrictionGraph::EdgeRange suffix_edges = rg.GetEdges(suffix_node);
for (int i = 0; i < suffix_edges.size(); i++)
{
    const auto &suffix_edge = suffix_edges[i];
    if (suffix_edge.is_transfer)
        continue;
//other code

After making these changes, I re-ran the unit tests, and the error related to the vector loop no longer occurred. And of course, I also tried building and running it again, and the issue has been fixed. osrm-extract.exe ran successfully without any errors.

Thanks.