Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ITER from ods issue related to pf_coils #522

Closed
TimSlendebroek opened this issue Mar 8, 2024 · 6 comments
Closed

new ITER from ods issue related to pf_coils #522

TimSlendebroek opened this issue Mar 8, 2024 · 6 comments
Assignees
Labels
bug Something isn't working help needed

Comments

@TimSlendebroek
Copy link
Contributor

It looks like the pf_active isn't quite working for the new ITER cases (made up off the different json files)

I tried running this:

ini,act = FUSE.case_parameters(:ITER;init_from=:ods);
dd = IMAS.dd()
FUSE.init(dd,ini,act);

FUSE.ActorEquilibrium(dd,act;ip_from=:pulse_schedule)
FUSE.ActorPFactive(dd,act;do_plot=true);

It runs through but all the coil currents are zero:

image

The regression tests pass because ActorPF_active isn't' part of the whole facility actor for ITER

@orso82 @lstagner

Torrin also gave us another pf_active json file (https://github.com/GA-IDA/FuseDatabase/files/14515689/ITER_MD_FUSE.json) which looks like it is different from FUSE/sample/ITER_pf_active_ods.json

@TimSlendebroek TimSlendebroek added bug Something isn't working help needed labels Mar 8, 2024
@lstagner
Copy link
Contributor

lstagner commented Mar 8, 2024

I took the pf_active from that JSON file torrin provided. So they should match up....actually using the latest download they are different...weird. Maybe torrin updated the comment link or I took it from the wrong comment. They had the same name

@lstagner
Copy link
Contributor

lstagner commented Mar 8, 2024

Could you give the ls/iter_pf_active branch a shot. I tried running the MWE but I get errors and I'm not sure if its due to my environment or something else.

@TimSlendebroek
Copy link
Contributor Author

#525

@lstagner
Copy link
Contributor

lstagner commented Mar 8, 2024

OK I'll close my pr

@TimSlendebroek
Copy link
Contributor Author

TimSlendebroek commented Mar 9, 2024

OK I'll close my pr

aah sorry I missed your PR

the regressions test fail because we switched the initalization process (and forgot to run make init_expressions )

@orso82
Copy link
Member

orso82 commented Mar 11, 2024

I am closing this, since the issue is not specific to ITER and #524 is open

@orso82 orso82 closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help needed
Projects
None yet
Development

No branches or pull requests

3 participants