Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop emitting Py_3_6 cfg #4583

Merged
merged 1 commit into from
Sep 27, 2024
Merged

stop emitting Py_3_6 cfg #4583

merged 1 commit into from
Sep 27, 2024

Conversation

davidhewitt
Copy link
Member

At the time of dropping 3.6, we couldn't remove Py_3_6 cfg support from pyo3-build-config at risk of silently breaking them.

Now with check-cfg in recent Rust versions, I think this can just silently be removed.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Sep 26, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Sep 27, 2024
Merged via the queue into PyO3:main with commit e053dbc Sep 27, 2024
44 checks passed
@davidhewitt davidhewitt deleted the drop-36-cfg branch September 27, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @Icxolu